Use solely Pilosa roaring bitmaps in m3ninx to avoid expensive unmarshalling #1196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## r/concurrent-index-block-queries #1196 +/- ##
==================================================================
- Coverage 71% 71% -0.1%
==================================================================
Files 739 739
Lines 62117 62135 +18
==================================================================
Hits 44142 44142
- Misses 15121 15135 +14
- Partials 2854 2858 +4
Continue to review full report at Codecov.
|
robskillington
force-pushed
the
r/use-pilosa-roaring-bitmaps
branch
from
7ecc724 to
ef8471b
Compare
|
Abandoned in favor of: #1238 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unmarshalling Pilosa bitmaps into the other RoaringBitmap library's bitmap was causing a ton of allocations.
Now that we solely use Pilosa bitmaps we entirely avoid the large allocations of copying the postings lists when searching FST segments with MatchTerm, MatchRegexp, etc.
Fixes #1192.