Respect numShards in /database/create #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| }, | ||
| "replicaFactor": 0, | ||
| "numShards": 0, |
There was a problem hiding this comment.
Why would you expect 0 shards in the response?
Codecov Report
@@ Coverage Diff @@
## master #1188 +/- ##
========================================
+ Coverage 71.1% 71.1% +<.1%
========================================
Files 737 737
Lines 61857 61858 +1
========================================
+ Hits 44006 44014 +8
+ Misses 15003 14996 -7
Partials 2848 2848
Continue to review full report at Codecov.
|
|
Not in the real world, but in this case, we'd just be testing whether whether our placement mock return is what we expect. The real thing we're testing in this new unit test is whether |
| "blockDataExpiry": true, | ||
| "blockDataExpiryAfterNotAccessPeriodNanos": "300000000000" | ||
| }, | ||
| "snapshotEnabled": false, |
There was a problem hiding this comment.
Hm why is snapshotEnabled false when using the database/create method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.