Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BuildKite Setup #1002

Merged
merged 3 commits into from
Oct 2, 2018
Merged

BuildKite Setup #1002

merged 3 commits into from
Oct 2, 2018

Conversation

prateek
Copy link
Collaborator

@prateek prateek commented Oct 2, 2018

pending:

  • ensure we wire up the CODECOV_TOKEN correctly

@codecov
Copy link

codecov bot commented Oct 2, 2018

Codecov Report

Merging #1002 into master will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1002      +/-   ##
==========================================
+ Coverage   77.46%   77.64%   +0.17%     
==========================================
  Files         412      412              
  Lines       34697    34653      -44     
==========================================
+ Hits        26878    26905      +27     
+ Misses       5945     5880      -65     
+ Partials     1874     1868       -6
Flag Coverage Δ
#dbnode 81.5% <ø> (+0.19%) ⬆️
#m3ninx 75.25% <ø> (ø) ⬆️
#query 63.15% <ø> (+0.08%) ⬆️
#x 84.72% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d36bf78...8a3dd34. Read the comment docs.

@prateek prateek force-pushed the prateek/buildkite/letsdothis branch 15 times, most recently from 1cf86b9 to ca64284 Compare October 2, 2018 05:05
@prateek prateek changed the title [WIP] BuildKite Setup BuildKite Setup Oct 2, 2018
@prateek prateek force-pushed the prateek/buildkite/letsdothis branch from 602898f to 87f1374 Compare October 2, 2018 06:19
plugins:
docker-compose#v2.5.1:
run: app
- name: ":docker: + services + metalint"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: ":docker: + services + metalint" -> "Integration (Docker), Services, Tools, Metalint" for consistency with the names of the other jobs.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure thing, will do.

Copy link
Collaborator

@robskillington robskillington left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than minor nit, this is pretty great 👍

@prateek prateek force-pushed the prateek/buildkite/letsdothis branch from 9217b0e to cb1c3b1 Compare October 2, 2018 18:12
@prateek prateek merged commit d1891c7 into master Oct 2, 2018
@prateek prateek deleted the prateek/buildkite/letsdothis branch October 2, 2018 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants