-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BuildKite Setup #1002
BuildKite Setup #1002
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1002 +/- ##
==========================================
+ Coverage 77.46% 77.64% +0.17%
==========================================
Files 412 412
Lines 34697 34653 -44
==========================================
+ Hits 26878 26905 +27
+ Misses 5945 5880 -65
+ Partials 1874 1868 -6
Continue to review full report at Codecov.
|
1cf86b9
to
ca64284
Compare
602898f
to
87f1374
Compare
.buildkite/pipeline.yml
Outdated
plugins: | ||
docker-compose#v2.5.1: | ||
run: app | ||
- name: ":docker: + services + metalint" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: ":docker: + services + metalint"
-> "Integration (Docker), Services, Tools, Metalint"
for consistency with the names of the other jobs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure thing, will do.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than minor nit, this is pretty great 👍
9217b0e
to
cb1c3b1
Compare
pending: