-
Notifications
You must be signed in to change notification settings - Fork 454
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add full integration test for graphite find endpoint
- Loading branch information
Showing
8 changed files
with
458 additions
and
20 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,217 @@ | ||
| // Copyright (c) 2019 Uber Technologies, Inc. | ||
| // | ||
| // Permission is hereby granted, free of charge, to any person obtaining a copy | ||
| // of this software and associated documentation files (the "Software"), to deal | ||
| // in the Software without restriction, including without limitation the rights | ||
| // to use, copy, modify, merge, publish, distribute, sublicense, and/or sell | ||
| // copies of the Software, and to permit persons to whom the Software is | ||
| // furnished to do so, subject to the following conditions: | ||
| // | ||
| // The above copyright notice and this permission notice shall be included in | ||
| // all copies or substantial portions of the Software. | ||
| // | ||
| // THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR | ||
| // IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, | ||
| // FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE | ||
| // AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER | ||
| // LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, | ||
| // OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN | ||
| // THE SOFTWARE. | ||
|
|
||
| package graphite | ||
|
|
||
| import ( | ||
| "bytes" | ||
| "encoding/json" | ||
| "fmt" | ||
| "net/http" | ||
| "net/url" | ||
| "sort" | ||
| "strings" | ||
| "testing" | ||
|
|
||
| "github.com/m3db/m3/src/query/models" | ||
| "github.com/m3db/m3/src/query/storage" | ||
| "github.com/m3db/m3/src/query/util/logging" | ||
|
|
||
| "github.com/golang/mock/gomock" | ||
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| type completeTagQueryMatcher struct { | ||
| matchers []models.Matcher | ||
| } | ||
|
|
||
| func (m *completeTagQueryMatcher) String() string { return "complete tag query" } | ||
| func (m *completeTagQueryMatcher) Matches(x interface{}) bool { | ||
| q, ok := x.(*storage.CompleteTagsQuery) | ||
| if !ok { | ||
| return false | ||
| } | ||
|
|
||
| if q.CompleteNameOnly { | ||
| return false | ||
| } | ||
|
|
||
| if len(q.FilterNameTags) != 1 { | ||
| return false | ||
| } | ||
|
|
||
| // both queries should filter on __g1__ | ||
| if !bytes.Equal(q.FilterNameTags[0], []byte("__g1__")) { | ||
| return false | ||
| } | ||
|
|
||
| if len(q.TagMatchers) != len(m.matchers) { | ||
| return false | ||
| } | ||
|
|
||
| for i, qMatcher := range q.TagMatchers { | ||
| if !bytes.Equal(qMatcher.Name, m.matchers[i].Name) { | ||
| return false | ||
| } | ||
| if !bytes.Equal(qMatcher.Value, m.matchers[i].Value) { | ||
| return false | ||
| } | ||
| if qMatcher.Type != m.matchers[i].Type { | ||
| return false | ||
| } | ||
| } | ||
|
|
||
| return true | ||
| } | ||
|
|
||
| var _ gomock.Matcher = &completeTagQueryMatcher{} | ||
|
|
||
| func b(s string) []byte { return []byte(s) } | ||
| func bs(ss ...string) [][]byte { | ||
| bb := make([][]byte, len(ss)) | ||
| for i, s := range ss { | ||
| bb[i] = b(s) | ||
| } | ||
|
|
||
| return bb | ||
| } | ||
|
|
||
| func setupStorage(ctrl *gomock.Controller) storage.Storage { | ||
| store := storage.NewMockStorage(ctrl) | ||
| // set up no children case | ||
| noChildrenMatcher := &completeTagQueryMatcher{ | ||
| matchers: []models.Matcher{ | ||
| {Type: models.MatchRegexp, Name: b("__g0__"), Value: b("foo")}, | ||
| {Type: models.MatchRegexp, Name: b("__g1__"), Value: b("b.*")}, | ||
| {Type: models.MatchNotRegexp, Name: b("__g2__"), Value: b(".*")}, | ||
| }, | ||
| } | ||
|
|
||
| noChildrenResult := &storage.CompleteTagsResult{ | ||
| CompleteNameOnly: false, | ||
| CompletedTags: []storage.CompletedTag{ | ||
| {Name: b("__g1__"), Values: bs("bug", "bar", "baz")}, | ||
| }, | ||
| } | ||
|
|
||
| store.EXPECT().CompleteTags(gomock.Any(), noChildrenMatcher, gomock.Any()). | ||
| Return(noChildrenResult, nil) | ||
|
|
||
| // set up children case | ||
| childrenMatcher := &completeTagQueryMatcher{ | ||
| matchers: []models.Matcher{ | ||
| {Type: models.MatchRegexp, Name: b("__g0__"), Value: b("foo")}, | ||
| {Type: models.MatchRegexp, Name: b("__g1__"), Value: b("b.*")}, | ||
| {Type: models.MatchRegexp, Name: b("__g2__"), Value: b(".*")}, | ||
| }, | ||
| } | ||
|
|
||
| childrenResult := &storage.CompleteTagsResult{ | ||
| CompleteNameOnly: false, | ||
| CompletedTags: []storage.CompletedTag{ | ||
| {Name: b("__g1__"), Values: bs("baz", "bix", "bug")}, | ||
| }, | ||
| } | ||
|
|
||
| store.EXPECT().CompleteTags(gomock.Any(), childrenMatcher, gomock.Any()). | ||
| Return(childrenResult, nil) | ||
|
|
||
| return store | ||
| } | ||
|
|
||
| type writer struct { | ||
| results []string | ||
| } | ||
|
|
||
| var _ http.ResponseWriter = &writer{} | ||
|
|
||
| func (w *writer) WriteHeader(_ int) {} | ||
| func (w *writer) Header() http.Header { return make(http.Header) } | ||
| func (w *writer) Write(b []byte) (int, error) { | ||
| if w.results == nil { | ||
| w.results = make([]string, 0, 10) | ||
| } | ||
|
|
||
| w.results = append(w.results, string(b)) | ||
| return len(b), nil | ||
| } | ||
|
|
||
| type result struct { | ||
| ID string `json:"id"` | ||
| Text string `json:"text"` | ||
| Leaf int `json:"leaf"` | ||
| Expandable int `json:"expandable"` | ||
| AllowChildren int `json:"allowChildren"` | ||
| } | ||
|
|
||
| type results []result | ||
|
|
||
| func (r results) Len() int { return len(r) } | ||
| func (r results) Swap(i, j int) { r[i], r[j] = r[j], r[i] } | ||
| func (r results) Less(i, j int) bool { | ||
| return strings.Compare(r[i].ID, r[j].ID) == -1 | ||
| } | ||
|
|
||
| func TestFind(t *testing.T) { | ||
| logging.InitWithCores(nil) | ||
|
|
||
| ctrl := gomock.NewController(t) | ||
| defer ctrl.Finish() | ||
|
|
||
| // setup storage and handler | ||
| store := setupStorage(ctrl) | ||
| handler := NewFindHandler(store) | ||
|
|
||
| // execute the query | ||
| w := &writer{} | ||
| req := &http.Request{ | ||
| URL: &url.URL{ | ||
| RawQuery: "query=foo.b*", | ||
| }, | ||
| } | ||
|
|
||
| handler.ServeHTTP(w, req) | ||
|
|
||
| // convert results to comparable format | ||
| require.Equal(t, 1, len(w.results)) | ||
| r := make(results, 0) | ||
| decoder := json.NewDecoder(bytes.NewBufferString((w.results[0]))) | ||
| require.NoError(t, decoder.Decode(&r)) | ||
| sort.Sort(r) | ||
|
|
||
| makeNoChildrenResult := func(t string) result { | ||
| return result{ID: fmt.Sprintf("foo.%s", t), Text: t, Leaf: 1, | ||
| Expandable: 0, AllowChildren: 0} | ||
| } | ||
|
|
||
| makeWithChildrenResult := func(t string) result { | ||
| return result{ID: fmt.Sprintf("foo.%s", t), Text: t, Leaf: 0, | ||
| Expandable: 1, AllowChildren: 1} | ||
| } | ||
|
|
||
| expected := results{ | ||
| makeNoChildrenResult("bar"), | ||
| makeWithChildrenResult("baz"), | ||
| makeWithChildrenResult("bix"), | ||
| makeWithChildrenResult("bug"), | ||
| } | ||
|
|
||
| require.Equal(t, expected, r) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.