Remove CacheAllMetadata caching policy (#1110)

* Remove CacheAllMetadata caching policy

.buildkite/pipeline.yml

@@ -44,13 +44,6 @@ steps:
         gopath-checkout#v1.0.1:
           import: github.com/m3db/m3
     <<: *common
-  - label: "Integration (dbnode All Metadata) %n"
-    parallelism: 2
-    command: make clean install-vendor test-ci-integration-dbnode cache_policy=all_metadata
-    plugins:
-      docker-compose#v2.5.1:
-        run: app
-    <<: *common
   - name: "Integration (dbnode Recently Read) %n"
     parallelism: 2
     command: make clean install-vendor test-ci-integration-dbnode cache_policy=recently_read

src/cmd/services/m3dbnode/config/bootstrap.go

@@ -53,9 +53,6 @@ type BootstrapConfiguration struct {
 	// Filesystem bootstrapper configuration.
 	Filesystem *BootstrapFilesystemConfiguration `yaml:"fs"`
 
-	// Peers bootstrapper configuration.
-	Peers *BootstrapPeersConfiguration `yaml:"peers"`
-
 	// Commitlog bootstrapper configuration.
 	Commitlog *BootstrapCommitlogConfiguration `yaml:"commitlog"`
 
@@ -72,28 +69,12 @@ func (bsc BootstrapConfiguration) fsNumProcessors() int {
 	return int(math.Ceil(float64(runtime.NumCPU()) * np))
 }
 
-// TODO: Remove once v1 endpoint no longer required.
-func (bsc BootstrapConfiguration) peersFetchBlocksMetadataEndpointVersion() client.FetchBlocksMetadataEndpointVersion {
-	version := client.FetchBlocksMetadataEndpointDefault
-	if peersCfg := bsc.Peers; peersCfg != nil {
-		version = peersCfg.FetchBlocksMetadataEndpointVersion
-	}
-	return version
-}
-
 // BootstrapFilesystemConfiguration specifies config for the fs bootstrapper.
 type BootstrapFilesystemConfiguration struct {
 	// NumProcessorsPerCPU is the number of processors per CPU.
 	NumProcessorsPerCPU float64 `yaml:"numProcessorsPerCPU" validate:"min=0.0"`
 }
 
-// BootstrapPeersConfiguration specifies config for the peers bootstrapper.
-type BootstrapPeersConfiguration struct {
-	// FetchBlocksMetadataEndpointVersion is the endpoint to use when fetching blocks metadata.
-	// TODO: Remove once v1 endpoint no longer required.
-	FetchBlocksMetadataEndpointVersion client.FetchBlocksMetadataEndpointVersion `yaml:"fetchBlocksMetadataEndpointVersion"`
-}
-
 // BootstrapCommitlogConfiguration specifies config for the commitlog bootstrapper.
 type BootstrapCommitlogConfiguration struct {
 	// ReturnUnfulfilledForCorruptCommitlogFiles controls whether the commitlog bootstrapper
@@ -171,7 +152,6 @@ func (bsc BootstrapConfiguration) New(
 				SetAdminClient(adminClient).
 				SetPersistManager(opts.PersistManager()).
 				SetDatabaseBlockRetrieverManager(opts.DatabaseBlockRetrieverManager()).
-				SetFetchBlocksMetadataEndpointVersion(bsc.peersFetchBlocksMetadataEndpointVersion()).
 				SetRuntimeOptionsManager(opts.RuntimeOptionsManager())
 			bs, err = peers.NewPeersBootstrapperProvider(pOpts, bs)
 			if err != nil {

src/cmd/services/m3dbnode/config/config_test.go

@@ -367,7 +367,6 @@ db:
     - noop-all
     fs:
       numProcessorsPerCPU: 0.125
-    peers: null
     commitlog: null
     cacheSeriesMetadata: null
   blockRetrieve: null