Fix datatype to match prom output (#871)

m3db · Aug 30, 2018 · 50bf110 · 50bf110
1 parent 606981d
commit 50bf110
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/query/api/v1/handler/prometheus/native/common.go b/src/query/api/v1/handler/prometheus/native/common.go
@@ -173,8 +173,8 @@ func renderResultsJSON(w io.Writer, series []*ts.Series, params models.RequestPa
 			}
 
 			jw.BeginArray()
-			jw.WriteFloat64(dp.Value)
 			jw.WriteInt(int(dp.Timestamp.Unix()))
+			jw.WriteString(valueToProm(dp.Value))
 			jw.EndArray()
 		}
 		jw.EndArray()
@@ -190,3 +190,7 @@ func renderResultsJSON(w io.Writer, series []*ts.Series, params models.RequestPa
 	jw.EndArray()
 	jw.Close()
 }
+
+func valueToProm(value float64) string {
+	return strconv.FormatFloat(value, 'f', -1, 64)
+}
diff --git a/src/query/api/v1/handler/prometheus/native/common_test.go b/src/query/api/v1/handler/prometheus/native/common_test.go
@@ -21,6 +21,7 @@
 package native
 
 import (
+	"math"
 	"net/http"
 	"net/url"
 	"testing"
@@ -74,3 +75,10 @@ func TestInvalidTarget(t *testing.T) {
 	assert.NotNil(t, p.Start)
 	require.Equal(t, err.Code(), http.StatusBadRequest)
 }
+
+func TestValueToProm(t *testing.T) {
+	assert.Equal(t, valueToProm(1.0), "1")
+	assert.Equal(t, valueToProm(1.2), "1.2")
+	assert.Equal(t, valueToProm(math.NaN()), "NaN")
+	assert.Equal(t, valueToProm(0.0119311), "0.0119311")
+}