Inheritance implementation for Fluent API #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oformaniuk Thank you very much for this PR! I am impressed that you were able to implement the feature in just 15 lines of code. I plan to write some additional tests and aim to merge it within the next two weeks. Best regards, |
m31coding
reviewed
Sep 26, 2024
| @@ -90,9 +90,9 @@ private ClassInfoResult CreateFluentApiClassInfoInternal( | |||
| FluentApiAttributeInfo fluentApiAttributeInfo = | |||
| FluentApiAttributeInfo.Create(attributeDataExtended.AttributeData, className); | |||
|
|
|||
| List<FluentApiInfo> infos = new List<FluentApiInfo>(); | |||
| HashSet<FluentApiInfo> infos = new HashSet<FluentApiInfo>(); | |||
There was a problem hiding this comment.
I think there can't be duplicates and we can stick with the list.
|
The implementation turned out to be more complex in cases where the base class contains private methods and private setters. In such scenarios, reflection must target the base class instead of the derived class. For example: namePropertyInfo = typeof(Person).GetProperty("Name", ...instead of namePropertyInfo = typeof(Student).GetProperty("Name", ...Best regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #29
Implementation recursively checks all base types for existence of
Fluent*attributes.