Handle ip changes #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Convert shell plugin to internal plugin The purpose of this PR is to embed the shell plugin in the main dkron binary, that will facilitate creating a single binary with the most important executor, for easy deployment using a single binary. * Remove debugging
* Release a light image tag Omit all plugins except the shell plugin that will be included in the main binary.
|
dkron is deployed to feature/try-147 now |
ivan-kripakov-m10
requested review from
michail-zubarev-m10,
viktor-denisov-m10,
ilnur-khafizov-m10 and
timur-flomin-m10
michail-zubarev-m10
approved these changes
Dec 21, 2023
ilnur-khafizov-m10
approved these changes
Dec 21, 2023
viktor-denisov-m10
approved these changes
Dec 22, 2023
…ent from server node IP on raft layer
ivan-kripakov-m10
force-pushed
the
handle_ip_changes
branch
2 times, most recently
from
f9c445b to
98be95b
Compare
…in server_lookup.go)
ivan-kripakov-m10
force-pushed
the
handle_ip_changes
branch
from
98be95b to
2d3e3d9
Compare
|
PR will be included in 4.x Dkron release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request is associated with issue distribworks#1442
I made several things here:
Query each of the servers and make sure they report no Raft peers.(I'm not sure if it is correct approach)I built image and tested it in k8s using this helm - distribworks/dkron-helm#7
Seems like everything works fine now