Cleanup #1
Merged
Cleanup #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
Jake-Shadle
added a commit
to EmbarkStudios/cargo-fetcher
that referenced
this pull request
Feb 3, 2022
bloblock had numerous outdated/unused dependencies which I've fixed in m0ssc0de/bloblock#1
Jake-Shadle
added a commit
to EmbarkStudios/cargo-fetcher
that referenced
this pull request
Feb 3, 2022
* Fix release.toml * Add and fixup all lints * Update all dependencies Replace chrono with time * Fixup CHANGELOG * Replace structopt with clap * Update libc * Fix git test * Temporarily vendor bloblock bloblock had numerous outdated/unused dependencies which I've fixed in m0ssc0de/bloblock#1 * Replace difference with similar-asserts * Nuke async code in favor of sync It's simpler, checking now if it is faster * Add version etc information * Fix lints * Update CHANGELOG
|
Thanks a lot. Your commits are pretty nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates all dependencies to latest since several of them were outdated and/or causing multiple versions to be used when used with other cloud libraries.
This also replaces chrono with time, because chrono was overkill and has also not been updated in a long time and has 2 security advisories currently on it. The chrono dependency was also only actually used by tests, so this just moves it to a dev-dependency.
Also fixes a few lint issues, moves test code to
#[cfg(test)]modules so that they are not unnecessarily compiled, and removes the Cargo.lock file since this is just a library crate.