This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
fix a small bug #87
Open
fix a small bug #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dear @changdingfang, we recently forked this repository to 1, see #88. Over there, we will be very happy to accept your patch. With kind regards, Footnotes |
amotl
pushed a commit
to grafana-toolbox/grafana-client
that referenced
this pull request
Jun 23, 2022
This improves a situation where the value of "totalCount" was inconsistent with the total length of "teams", which resulted in a loop that could not be returned. References: - m0nhawk/grafana_api#87 - #12
|
Dear @changdingfang, we have been tracking this topic with grafana-toolbox/grafana-client#12, and we just included your fix with grafana-toolbox/grafana-client@3d6d9c985. Thank you again and with kind regards, |
amotl
pushed a commit
to grafana-toolbox/grafana-client
that referenced
this pull request
Jun 25, 2022
This improves a situation where the value of "totalCount" was inconsistent with the total length of "teams", which resulted in a loop that could not be returned. References: - m0nhawk/grafana_api#87 - #12
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I encountered a situation where the value of "totalCount" was inconsistent with the total length of "team", which resulted in a loop that could not be returned.
So I modified the break condition and solved the problem.
Sorry, my English is not good, this is done with Google Translate, I hope my expression and translation are very clear