Skip to content
This repository has been archived by the owner on Aug 2, 2022. It is now read-only.

backward compatibility with python2.7 ; see https://stackoverflow.com… #22

Merged
merged 1 commit into from
Apr 28, 2019
Merged

backward compatibility with python2.7 ; see https://stackoverflow.com… #22

merged 1 commit into from
Apr 28, 2019

Conversation

OlegKorchagin
Copy link

…/questions/38963018

Pull Request Template

Description

add backward compatibility with python 2.7 ( https://stackoverflow.com/questions/38963018 )

Have you written tests?

  • Yes
  • No

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   43.93%   43.93%           
=======================================
  Files          12       12           
  Lines         412      412           
=======================================
  Hits          181      181           
  Misses        231      231
Impacted Files Coverage Δ
grafana_api/api/datasource.py 34.14% <100%> (ø) ⬆️
grafana_api/api/folder.py 34.21% <100%> (ø) ⬆️
grafana_api/api/user.py 31.25% <100%> (ø) ⬆️
grafana_api/api/dashboard.py 36.36% <100%> (ø) ⬆️
grafana_api/api/admin.py 36.36% <100%> (ø) ⬆️
grafana_api/api/organization.py 34.14% <100%> (ø) ⬆️
grafana_api/api/search.py 23.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52037ae...d13e770. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #22 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   43.93%   43.93%           
=======================================
  Files          12       12           
  Lines         412      412           
=======================================
  Hits          181      181           
  Misses        231      231
Impacted Files Coverage Δ
grafana_api/api/datasource.py 34.14% <100%> (ø) ⬆️
grafana_api/api/folder.py 34.21% <100%> (ø) ⬆️
grafana_api/api/user.py 31.25% <100%> (ø) ⬆️
grafana_api/api/dashboard.py 36.36% <100%> (ø) ⬆️
grafana_api/api/admin.py 36.36% <100%> (ø) ⬆️
grafana_api/api/organization.py 34.14% <100%> (ø) ⬆️
grafana_api/api/search.py 23.07% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52037ae...d13e770. Read the comment docs.

Copy link
Owner

@m0nhawk m0nhawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding Python 2.7.

@m0nhawk m0nhawk merged commit 76e7f7b into m0nhawk:master Apr 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants