Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence some float conversion warnings by making conversion explicit #6

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Silence some float conversion warnings by making conversion explicit #6

merged 1 commit into from
Jun 2, 2023

Conversation

ywwg
Copy link

@ywwg ywwg commented May 30, 2023

No description provided.

@github-actions github-actions bot added the ui label May 30, 2023
@ywwg ywwg mentioned this pull request May 30, 2023
Merged
@ywwg ywwg force-pushed the build-with-qt6-optional-qml branch 2 times, most recently from 1298391 to 7df16c4 Compare May 31, 2023 15:32
@coveralls
Copy link

coveralls commented May 31, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5135164813

  • 0 of 33 (0.0%) changed or added relevant lines in 11 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.005%) to 32.04%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/waveform/renderers/allshader/waveformrenderbeat.cpp 0 1 0.0%
src/waveform/renderers/allshader/waveformrendererendoftrack.cpp 0 1 0.0%
src/waveform/renderers/allshader/waveformrendermark.cpp 0 1 0.0%
src/waveform/renderers/allshader/waveformrendermarkrange.cpp 0 1 0.0%
src/widget/woverviewhsv.cpp 0 1 0.0%
src/waveform/renderers/waveformmarkrange.cpp 0 2 0.0%
src/waveform/renderers/waveformrendererhsv.cpp 0 2 0.0%
src/waveform/renderers/waveformrendermark.cpp 0 2 0.0%
src/widget/openglwindow.cpp 0 2 0.0%
src/widget/woverview.cpp 0 2 0.0%
Totals Coverage Status
Change from base Build 5124724347: -0.005%
Covered Lines: 26606
Relevant Lines: 83039
💛 - Coveralls

@ywwg ywwg marked this pull request as draft May 31, 2023 16:07
@ywwg
Copy link
Author

ywwg commented May 31, 2023

still finding issues

@ywwg ywwg force-pushed the build-with-qt6-optional-qml branch from 7df16c4 to d7c37a9 Compare May 31, 2023 16:08
@ywwg
Copy link
Author

ywwg commented May 31, 2023

all builds pass!

@ywwg ywwg marked this pull request as ready for review May 31, 2023 19:46
@m0dB m0dB merged commit 3137224 into m0dB:build-with-qt6-optional-qml Jun 2, 2023
m0dB pushed a commit that referenced this pull request Feb 16, 2024
@fwcd
Merge pull request #6 from fwcd/fixversionstore
cdf87b9 
VersionStore: Remove Apple fallback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ywwg @coveralls @m0dB