Imports are now expressions #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| ExpressionGraph g; | ||
| try { | ||
| g = parser.parseFile(importedFile); |
There was a problem hiding this comment.
I don't think this is the best place to put this, but I'm not really sure where it would make the most sense. The alternative that seems to make the most sense is during elaboration of the ImportVertex.
There was a problem hiding this comment.
If I understand this correctly, it would make sense to me to have the import resolved during elaboration. I can see it being beneficial to keeping our simple graph views, well, simple. You know more about the process and performance so it's your call.
There was a problem hiding this comment.
Since there's no reason to parse a file if the import isn't used I'm going to move this in
|
Fix it and 🚢! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.