Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icmp to autonode firewall #105

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Oct 15, 2024

This change adds icmp to the ndt-server firewall rule used by the autonode VMs. By allowing icmp we can run traceroute-caller.

While the web ui reports protocol 58 as "ipv6-icmp", this value in the terraform config generates this error:

Error: Error updating Firewall "projects/mlab-sandbox/global/firewalls/ndt-access-ipv6": googleapi: 
Error 400: Invalid value for field 'resource.allowed[1].IPProtocol': 'ipv6-icmp'. Must be one of 
["ah", "all", "esp", "icmp", "ipip", "sctp", "tcp", "udp"] or an IP protocol number between 0 and 255., invalid

This change is Reviewable

@stephen-soltesz stephen-soltesz marked this pull request as ready for review October 15, 2024 19:19
Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

Copy link
Contributor

@robertodauria robertodauria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit fea1b54 into main Oct 16, 2024
3 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-autojoin-firewall-ndt-server branch October 16, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants