Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary query prototype #67

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Canary query prototype #67

wants to merge 4 commits into from

Conversation

gfr10598
Copy link
Contributor

@gfr10598 gfr10598 commented Jul 19, 2021

DRAFT - for discussion.

Decided this is a much better place to work on improving the query, so I can keep track of the changes I make. The initial commit is not too different from the original query in m-lab/analysis#12

Also tracking this query at:
https://console.cloud.google.com/bigquery?sq=581276032543:e7d8a3fd106549ebb7b00959f8068d50

I've updated a number of intermediate table names for better clarity. Also, removed some fields and commented out lines that are not needed or used.

Still needs a lot better documentation, and probably some simplification.


This change is Reviewable

@coveralls
Copy link

coveralls commented Jul 19, 2021

Pull Request Test Coverage Report for Build 24

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 24 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-1.9%) to 53.271%

Files with Coverage Reduction New Missed Lines %
pipeline/handlers.go 5 70.0%
histogram/table.go 19 75.53%
Totals Coverage Status
Change from base Build 11: -1.9%
Covered Lines: 285
Relevant Lines: 535

💛 - Coveralls

@robertodauria robertodauria removed their request for review April 28, 2022 12:12
@SaiedKazemi SaiedKazemi changed the base branch from master to main August 11, 2022 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants