Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new state after uuidwait and before dircreation #32

Merged
merged 2 commits into from
Dec 3, 2019

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Dec 3, 2019

Currently the saver state appears to stall at "uuidwait" even though uuid handling occurs immediately. This change adds a new state for "readingpackets-withuuid".

My only reservation is that the new state name is kind of long. Suggestions welcome.


This change is Reviewable

@coveralls
Copy link

coveralls commented Dec 3, 2019

Pull Request Test Coverage Report for Build 161

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.8%) to 99.226%

Files with Coverage Reduction New Missed Lines %
main.go 4 95.12%
Totals Coverage Status
Change from base Build 153: -0.8%
Covered Lines: 513
Relevant Lines: 517

💛 - Coveralls

Copy link
Contributor

@pboothe pboothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 approvals obtained (waiting on @pboothe)

Copy link
Contributor

@pboothe pboothe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit c778536 into master Dec 3, 2019
@pboothe pboothe deleted the sandbox-soltesz-new-state branch December 3, 2019 21:39
@stephen-soltesz
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants