-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix logs, memory usage, header size #21
Conversation
Instead, buffer packet headers in in-memory files. Fixes #20
Pull Request Test Coverage Report for Build 94
💛 - Coveralls |
Fixes #18
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blocking only b/c the definition of "LayerContents" and "LayerPayload" is still a little fuzzy to me. It sounded like you were planning to add a comment.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @pboothe and @stephen-soltesz)
saver/tcp.go, line 160 at r2 (raw file):
https://en.wikipedia.org/wiki/Transmission_Control_Protocol#TCP_segment_structure
I actually don't have a good grasp on which parts of the packet correspond to "LayerContents" and "LayerPayload". Please help me with this either conversationally or an extra comment.
saver/tcp_test.go, line 123 at r2 (raw file):
s.state = &tracker h, err := pcap.OpenOffline("../testdata/v4.pcap")
... how did these work before? ... O_o
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 1 change requests, 0 of 1 approvals obtained (waiting on @stephen-soltesz)
saver/tcp.go, line 160 at r2 (raw file):
Previously, stephen-soltesz (Stephen Soltesz) wrote…
https://en.wikipedia.org/wiki/Transmission_Control_Protocol#TCP_segment_structure
I actually don't have a good grasp on which parts of the packet correspond to "LayerContents" and "LayerPayload". Please help me with this either conversationally or an extra comment.
Done.
saver/tcp_test.go, line 123 at r2 (raw file):
Previously, stephen-soltesz (Stephen Soltesz) wrote…
... how did these work before? ... O_o
When the UUID stuff happened before packet handling, we didn't need to read any packets to exercise UUID error cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 3 files at r1, 1 of 1 files at r3.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @pboothe)
saver/tcp.go, line 160 at r3 (raw file):
tl := p.TransportLayer() if tl != nil { // "LayerContents" == the header (I don't know why it's not "LayerHeader")
"the header" == "the TCP header"?
Fixes #18
Fixes #20
This change is