Adds new -type and -uplink flags to register command

[nkinkade]

This allows Autojoin clients to specify these v2.Registration fields and pass them to the Autojoin API as part of the registration process.

---

This change is 

[coveralls]

Pull Request Test Coverage Report for Build 12060924129

Details

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 98.142%

---

Totals
Change from base Build 12059416068:	0.0%
Covered Lines:	1215
Relevant Lines:	1238

---

💛 - Coveralls

[stephen-soltesz]

Reviewable status: 0 of 1 approvals obtained (waiting on @nkinkade)

---

cmd/register/main.go line 43 at r1 (raw file):

	ipv4        = flagx.StringFile{}
	ipv6        = flagx.StringFile{}
	machineType = flag.String("type", "", "The type of machine: physical or virtual")

Do you want these to be flagx.StringFiles also?

[nkinkade]

Reviewable status: 0 of 1 approvals obtained (waiting on @stephen-soltesz)

---

cmd/register/main.go line 43 at r1 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…

Do you want these to be flagx.StringFiles also?

I couldn't think of a use case. For M-Lab-managed VMs, there is no current metadata file that has anything about the fact that the machine is a VM, nor the uplink speed. For M-Lab-managed machines, for now only virtual machines will be using the Autojoin API, and it is easy enough to set the -type flag of the autonode-register container to "virtual". As far as the uplink speed, as far as I know the only way to understanding the uplink speed is to read the GCE documentation. I presume the same is true for other cloud providers.

Are you imagining a case where those values would be written to a file by write-metadata.sh or similar and then read in by the register container?

[stephen-soltesz]

Thank you for this addition!!

Reviewable status: complete! 1 of 1 approvals obtained

---

cmd/register/main.go line 43 at r1 (raw file):

Previously, nkinkade wrote…

I couldn't think of a use case. For M-Lab-managed VMs, there is no current metadata file that has anything about the fact that the machine is a VM, nor the uplink speed. For M-Lab-managed machines, for now only virtual machines will be using the Autojoin API, and it is easy enough to set the -type flag of the autonode-register container to "virtual". As far as the uplink speed, as far as I know the only way to understanding the uplink speed is to read the GCE documentation. I presume the same is true for other cloud providers.

Are you imagining a case where those values would be written to a file by write-metadata.sh or similar and then read in by the register container?

Thank you - I wasn't thinking through the specific cases. In the future, I could imagine if we want to use register for the physical nodes too. But, this doesn't need to be added now.

[nkinkade]

Reviewable status: complete! 1 of 1 approvals obtained

---

cmd/register/main.go line 43 at r1 (raw file):

Previously, stephen-soltesz (Stephen Soltesz) wrote…

Thank you - I wasn't thinking through the specific cases. In the future, I could imagine if we want to use register for the physical nodes too. But, this doesn't need to be added now.

I definitely have in mind investigating the use of Autojoin for physical machines too. Offloading DNS management from siteinfo seems desirable, and would be one less dependency on mlabconfig.py, which feels like another legacy piece of software that we rely on heavily today.