Change -probability flag to type flagx.StringFile #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This requires a little backbending and conversion of float64s to strings and vice versa in order to be able to maintain the check that the value is not <=0.0 or >1.0. This change will allow plumbing the site probability for VMs through to the register command via our Terraform configs. The value will be written to /var/local/metadata/probability.
Pull Request Test Coverage Report for Build 12038039131Details
💛 - Coveralls |
stephen-soltesz
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 1 of 1 approvals obtained
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is rather ugly and requires a little back bending and conversion of float64s to strings and vice versa in order to be able to maintain the check that the value is not <=0.0 or >1.0.
This change will allow plumbing the site probability for VMs through to the register command via our Terraform configs. The value will be written to /var/local/metadata/probability.
This change is