Convert three register flags to type flagx.StringFile #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be used to assist in having M-Lab managed VMs use the register command, where today several of the flag values are located in /var/local/metadata.
Pull Request Test Coverage Report for Build 12035672610Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are working on having M-Lab managed VMs leverage the Autojoin API in order to get a dynamic DNS name. The value of several of the flags to the
registercommand are already present on the local filesystem of our VMs in the /var/local/metadata directory. Namely, external IPv4 and IPv6 addresses and the IATA code for the site. This PR coverts the-iata,-ipv4and-ipv6flags to be of type flagx.StringFile, which allow us to specify a path to a file instead of a static string value for these flags.This change is