Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dispatch.yaml to route autojoin API requests to the autojoin service #53

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Nov 8, 2024

It is always possible to use URLs constructed by App Engine, such as:

However, App Engine also allows custom domains, such as:

Like locate.measurementlab.net and the dispatch.yaml config for mlab-ns this PR adds a dispatch.yaml configuration for the production deployment of the autojoin API so autojoin.measurementlab.net can be the canonical API name.


This change is Reviewable

@stephen-soltesz stephen-soltesz marked this pull request as ready for review November 8, 2024 19:44
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11748539519

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.918%

Totals Coverage Status
Change from base Build 11731151423: 0.0%
Covered Lines: 1189
Relevant Lines: 1202

💛 - Coveralls

Copy link

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit f443e38 into main Nov 8, 2024
8 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-add-dispatch branch November 8, 2024 21:01
@stephen-soltesz
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants