Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for managing Cloud DNS zones #44

Merged
merged 5 commits into from
Sep 10, 2024

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Sep 10, 2024

This change updates the dnsx.Manager by adding two new methods for: RegisterZone and RegisterZoneSplit. The combination of these methods will make it possible to register a new organization and create the Cloud DNS zone and resource records needed by autojoined nodes from that organization.

A zone split works in two steps:

  • Create a new zone for the organization, which automatically includes NS records, e.g. foo.sandbox.measurement-lab.org
  • Add a new NS record to the parent project zone, which is the "split" and allows DNS resolvers to recursively lookup a name, e.g. sandbox.measurement-lab.org contains the NS records for foo.sandbox.measurement-lab.org

This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Sep 10, 2024

Pull Request Test Coverage Report for Build 10796257601

Details

  • 42 of 42 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 98.803%

Totals Coverage Status
Change from base Build 10784136990: 0.05%
Covered Lines: 1073
Relevant Lines: 1086

💛 - Coveralls

@stephen-soltesz stephen-soltesz changed the title Add support for managing zones and registering a new organization zone split Add support for managing Cloud DNS zones Sep 10, 2024
@stephen-soltesz stephen-soltesz marked this pull request as ready for review September 10, 2024 16:08
Copy link

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit f9b2412 into main Sep 10, 2024
8 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-register-dns branch September 10, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants