-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for dnsx.Manager to operate on zones #43
Conversation
Pull Request Test Coverage Report for Build 10781942816Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @stephen-soltesz)
internal/dnsname/names.go
line 10 at r1 (raw file):
} // OrgZone returns the organization zone name based the given organization and
based on?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Reviewable status: complete! 1 of 1 approvals obtained (waiting on @cristinaleonr)
internal/dnsname/names.go
line 10 at r1 (raw file):
Previously, cristinaleonr (Cristina Leon) wrote…
based on?
Fixed!
This change includes two updates:
dnsname
that now includesOrgZone
and two new functions forProjectZone
andOrgDNS
, both of which will be needed to generate the project and org zone names.dnsiface.Service
interface to includes methods toGetManagedZone
andCreateManagedZone
.dnsiface.NewCloudDNSService
for consistency with other interface typesThis change is