Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for dnsx.Manager to operate on zones #43

Merged
merged 9 commits into from
Sep 10, 2024

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Sep 9, 2024

This change includes two updates:

  • Adds a new package dnsname that now includes OrgZone and two new functions for ProjectZone and OrgDNS, both of which will be needed to generate the project and org zone names.
  • Extends the dnsiface.Service interface to includes methods to GetManagedZone and CreateManagedZone.
  • Adds dnsiface.NewCloudDNSService for consistency with other interface types

This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Sep 9, 2024

Pull Request Test Coverage Report for Build 10781942816

Details

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 98.755%

Totals Coverage Status
Change from base Build 10724385039: 0.007%
Covered Lines: 1031
Relevant Lines: 1044

💛 - Coveralls

@stephen-soltesz stephen-soltesz marked this pull request as ready for review September 9, 2024 21:46
Copy link

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @stephen-soltesz)


internal/dnsname/names.go line 10 at r1 (raw file):

}

// OrgZone returns the organization zone name based the given organization and

based on?

Copy link
Contributor Author

@stephen-soltesz stephen-soltesz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Reviewable status: :shipit: complete! 1 of 1 approvals obtained (waiting on @cristinaleonr)


internal/dnsname/names.go line 10 at r1 (raw file):

Previously, cristinaleonr (Cristina Leon) wrote…

based on?

Fixed!

@stephen-soltesz stephen-soltesz merged commit af21ff6 into main Sep 10, 2024
8 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-dnsiface-zones branch September 10, 2024 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants