Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Lookup handler implementation #4

Merged
merged 7 commits into from
Feb 13, 2024

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Feb 12, 2024

This change provides a basic implementation for handler Server.Lookup. This is a user-facing interface to help operators identify the correct IATA for a given site.

$ curl `https://autojoin-dot-mlab-sandbox.appspot.com/autojoin/v0/lookup`
cdw

$ curl 'https://autojoin-dot-mlab-sandbox.appspot.com/autojoin/v0/lookup?lat=40.76&lon=-73.86'
lga

This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Feb 12, 2024

Pull Request Test Coverage Report for Build 7878593887

Details

  • 0 of 52 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 7878371784: 0.0%
Covered Lines: 136
Relevant Lines: 136

💛 - Coveralls

@stephen-soltesz stephen-soltesz changed the title Sandbox soltesz lookup handler Add Lookup handler implementation Feb 12, 2024
@stephen-soltesz stephen-soltesz marked this pull request as ready for review February 13, 2024 00:02
Copy link

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

Copy link

@cristinaleonr cristinaleonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz stephen-soltesz merged commit 41ffde8 into main Feb 13, 2024
7 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-lookup-handler branch February 13, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants