Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add secret manager for storing and loading SA keys #39

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

stephen-soltesz
Copy link
Contributor

@stephen-soltesz stephen-soltesz commented Sep 3, 2024

This change adds a new type adminx.SecretManager that uses the adminx.ServiceAccountManager to load or create and store service account keys in Google Cloud Secret manager.

With this change and the adminx package, it should be possible to add service account key distribution to the Register API so that new nodes can join using in-band configuration.


This change is Reviewable

@coveralls
Copy link
Collaborator

coveralls commented Sep 3, 2024

Pull Request Test Coverage Report for Build 10689240323

Details

  • 96 of 96 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 98.568%

Totals Coverage Status
Change from base Build 10687864932: 0.2%
Covered Lines: 895
Relevant Lines: 908

💛 - Coveralls

Copy link
Contributor

@nkinkade nkinkade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 1 approvals obtained

@stephen-soltesz
Copy link
Contributor Author

Thank you!

@stephen-soltesz stephen-soltesz merged commit 64def73 into main Sep 3, 2024
8 checks passed
@stephen-soltesz stephen-soltesz deleted the sandbox-soltesz-secrets branch September 3, 2024 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants