Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 3.0.0 #623

Merged
merged 17 commits into from
Oct 13, 2023
Merged

Version 3.0.0 #623

merged 17 commits into from
Oct 13, 2023

Conversation

susannalandstrom
Copy link
Contributor

Background

Update to the Button component and dependencies.

💡 Feature 1

🛠 Dependency updates

⚠️ BREAKING CHANGES ⚠️

  • Button does not have chunky property anymore, instead three sizes (large, medium, small)
  • Alignment of page headers and buttons needs to be checked.
  • danger color variant has been renamed to error
  • disabledBg property has been removed from ColorStateOption interface -> Theme does not have primaryStates.disabledBg or lightStates.disabledBg prop anymore and these colours need to be replaces with some other colours in portal.

dependabot bot and others added 17 commits September 25, 2023 17:16
Bumps [@storybook/nextjs](https://github.com/storybookjs/storybook/tree/HEAD/code/frameworks/nextjs) from 7.0.10 to 7.4.5.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v7.4.5/code/frameworks/nextjs)

---
updated-dependencies:
- dependency-name: "@storybook/nextjs"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.6.0 to 20.7.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@mui/x-date-pickers](https://github.com/mui/mui-x/tree/HEAD/packages/x-date-pickers) from 6.4.0 to 6.16.0.
- [Release notes](https://github.com/mui/mui-x/releases)
- [Changelog](https://github.com/mui/mui-x/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mui/mui-x/commits/v6.16.0/packages/x-date-pickers)

---
updated-dependencies:
- dependency-name: "@mui/x-date-pickers"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…te-pickers-6.16.0

build(deps): bump @mui/x-date-pickers from 6.4.0 to 6.16.0
…de-20.7.2

build(deps-dev): bump @types/node from 20.6.0 to 20.7.2
…k/nextjs-7.4.5

build(deps-dev): bump @storybook/nextjs from 7.0.10 to 7.4.5
Bumps [@mui/x-license-pro](https://github.com/mui/mui-x/tree/HEAD/packages/x-license-pro) from 6.0.4 to 6.10.2.
- [Release notes](https://github.com/mui/mui-x/releases)
- [Changelog](https://github.com/mui/mui-x/blob/master/CHANGELOG.md)
- [Commits](https://github.com/mui/mui-x/commits/v6.10.2/packages/x-license-pro)

---
updated-dependencies:
- dependency-name: "@mui/x-license-pro"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@storybook/react](https://github.com/storybookjs/storybook/tree/HEAD/code/renderers/react) from 7.0.24 to 7.4.6.
- [Release notes](https://github.com/storybookjs/storybook/releases)
- [Changelog](https://github.com/storybookjs/storybook/blob/next/CHANGELOG.md)
- [Commits](https://github.com/storybookjs/storybook/commits/v7.4.6/code/renderers/react)

---
updated-dependencies:
- dependency-name: "@storybook/react"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…k/react-7.4.6

build(deps-dev): bump @storybook/react from 7.0.24 to 7.4.6
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.7.2 to 20.8.3.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…cense-pro-6.10.2

build(deps): bump @mui/x-license-pro from 6.0.4 to 6.10.2
…de-20.8.3

build(deps-dev): bump @types/node from 20.7.2 to 20.8.3
@susannalandstrom susannalandstrom requested a review from a team as a code owner October 12, 2023 10:00
Copy link
Contributor

@kacperkosinski kacperkosinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @susannalandstrom 👍

It makes sense to have color states for action results e.g. success, error, warning, and info, but I'm so not sure about these states that were present in the theme before - for example lightStates, primaryStates, and secondaryStates 🤔 It doesn't sound as this variants should have a state attached to them, at the same point we could have greenStates, darkStates, etc.
Of course, these were there before, so it's just me thinking out loud, maybe a topic for another day's discussion 😄

@susannalandstrom
Copy link
Contributor Author

Looks good @susannalandstrom 👍

It makes sense to have color states for action results e.g. success, error, warning, and info, but I'm so not sure about these states that were present in the theme before - for example lightStates, primaryStates, and secondaryStates 🤔 It doesn't sound as this variants should have a state attached to them, at the same point we could have greenStates, darkStates, etc. Of course, these were there before, so it's just me thinking out loud, maybe a topic for another day's discussion 😄

Yeah, there might be more changes to these when we move forward with the other components. There has not been clear decisions yet about all the colors that we would need so these might very well change still.

@susannalandstrom susannalandstrom merged commit b60b235 into main Oct 13, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants