Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.0.2 #27

Merged
merged 19 commits into from
Mar 30, 2022
Merged

Version 1.0.2 #27

merged 19 commits into from
Mar 30, 2022

Conversation

PetroSilenius
Copy link
Contributor

@PetroSilenius PetroSilenius commented Feb 28, 2022

🌡️ Progress and Tooltip component props optional, uses defaults

  • color, type and variant props for the Progress component are now optional and use default values if no prop is passed.
  • arrow prop for the Tooltip is now optional and uses the default value of true when the prop is not passed.

New TimePicker component

Upgrading dependencies

  • Upgrades next.js to 12.1.2 and eslint to 8.12
  • Downgrades @types/node to match used node v16
  • Upgrades other dependencies and addresses some vulnerabilities at the same time
  • Adds moment and dayjs as devdepencies since they were causing errors locally with @date/io

Fixes

  • Passing data-testid to Select component when using multiple prop (pass missing testid #28 )
  • Passing all given props to IconButton
  • Dialog Close button now triggers onClose function
  • Changes default Datepicker stories adapter to dayjs
  • Adds default MUI tab panel component export

@PetroSilenius PetroSilenius requested a review from a team as a code owner February 28, 2022 12:28
@PetroSilenius
Copy link
Contributor Author

Linting is failing due to a bug in eslint-plugin-react that is a dependency of eslint-plugin-next.

Fixed in the canary version of eslin-plugin-next. I'd recommend waiting for 12.1.1. release instead of doing resolutions magic here. The changes here are not urgent and no harm is done by waiting for the eslint-plugin-next release

kacperkosinski
kacperkosinski previously approved these changes Feb 28, 2022
@PetroSilenius
Copy link
Contributor Author

eslint-plugin-next upgraded to v12.1.2 in this PR

Should fix the linting issues

Upgrade dependencies with npm upgrade and npm outdated
Copy link
Contributor

@susannalandstrom susannalandstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and nice description on what has been done! 🎉

kacperkosinski
kacperkosinski previously approved these changes Mar 30, 2022
@susannalandstrom susannalandstrom dismissed stale reviews from kacperkosinski and themself via d696d39 March 30, 2022 06:15
@PetroSilenius PetroSilenius merged commit 7222123 into main Mar 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants