Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: crypto_box_seed_keypair to derive key pair #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

DiogoAbu
Copy link
Contributor

This will add crypto_box_seed_keypair that allows to derive a key pair from a seed key.
Add type for to the new function and fix typo on types.

This was proposed by me before on #37

Copy link
Owner

@lyubo lyubo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment on sodium-jni.c file

unsigned char *seed = (unsigned char *) (*jenv)->GetByteArrayElements(jenv, j_seed, 0);
int result = (int)crypto_box_seed_keypair(pk, sk, seed);
(*jenv)->ReleaseByteArrayElements(jenv, j_pk, (jbyte *) pk, 0);
(*jenv)->ReleaseByteArrayElements(jenv, j_sk, (jbyte *) sk, 0);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

j_seed is not released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants