allow only one confirmation #519
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
|
@lynndylanhurley appears to be a decently sized security hole that's also easy to merge! |
|
I'm down to merge this right after #410 if it gets approval from one other person. |
zachfeldman
approved these changes
Oct 9, 2017
lynndylanhurley
approved these changes
Oct 17, 2017
|
Changes look good, I'll resolve the conflicts with the test file. We can merge once the conflicts are resolved. |
MaicolBen
approved these changes
Oct 17, 2017
|
It's very encouraging that each issue I've bumped while using this library has either been 1) recently fixed, 2) has a PR pending or 3) has a documented workaround. 👍 |
|
@MaicolBen Hi. I Don't have a Dev environment anymore. I can't help at this time. |
|
No problem, when I have a chance I'll do it myself |
|
Thanks for the understanding. Continue with the good work. BR. |
|
I opened this PR with the conflicts solved (because I can't push to a fork) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user confirms and account (after a registration), if the registration is valid, the user is logged in automatically in the system.
After a successful confirmation the user can still use the confirmation email to login into the system (without a password) and this represents a security flaw.
If the token is valid and if the user is already confirmed, the devise_token_auth should return an expired token. This will raise an auth:email-confirmation-error in ng-token-auth.
This will require #410 because it looks for sign_in counter.