Fix locales errors.messages.already_in_use + clean up
#466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. The locale files have been cleaned to be more consistent. Some mistakes have been corrected.
2. By convention in Rails, `errors` locale key is structured as follow:
```yaml
errors:
format: "%{attribute} %{message}"
messages:
accepted: must be accepted
```
It would be nicer to have devise_token_auth following it. So the structure as be re-arrange and the code updated.
|
I have tested it, calling my own repo and branch from my Gemfile. It works great. The locale is correctly changed. |
|
This looks great @ValentinTrinque . Thanks! |
booleanbetrayal
added a commit
that referenced
this pull request
Dec 14, 2015
Fix locales `errors.messages.already_in_use` + clean up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #463