-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
confirm_success_url shouldn't be a required param #176
Comments
I don't understand why this is set on the front side. I think the best solution should be to determine the URL on the configuration file of this gem. |
I agree I plan to add a commit to have a default confirm success url in the I can add. On Tuesday, March 10, 2015, Nicolas Besnard [email protected]
|
The I'm open to allowing an optional default |
I just pushed a fix for this in version |
I'm probably missing the point but...
It seems odd that devise_token_auth requires me to pass a confirm_success_url with the creation of the user.
While it is nice to be able to control this at the request level, I would think that it's default behavior should be to use a default confirm_success_url defined somewhere in the rails layer.
I'm happy to open a pr, but wanted to get some weigh-in on where this makes the most sense to be defined?
The text was updated successfully, but these errors were encountered: