Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confirm_success_url shouldn't be a required param #176

Closed
aesnyder opened this issue Mar 9, 2015 · 4 comments
Closed

confirm_success_url shouldn't be a required param #176

aesnyder opened this issue Mar 9, 2015 · 4 comments

Comments

@aesnyder
Copy link
Contributor

aesnyder commented Mar 9, 2015

I'm probably missing the point but...

It seems odd that devise_token_auth requires me to pass a confirm_success_url with the creation of the user.

While it is nice to be able to control this at the request level, I would think that it's default behavior should be to use a default confirm_success_url defined somewhere in the rails layer.

I'm happy to open a pr, but wanted to get some weigh-in on where this makes the most sense to be defined?

@nicolas-besnard
Copy link
Contributor

I don't understand why this is set on the front side. I think the best solution should be to determine the URL on the configuration file of this gem.

@aesnyder
Copy link
Contributor Author

I agree I plan to add a commit to have a default confirm success url in the
rails config.

I can add.

On Tuesday, March 10, 2015, Nicolas Besnard [email protected]
wrote:

I don't understand why this is set on the front side. I think the best
solution should be to determine the URL on the configuration file of this
gem.


Reply to this email directly or view it on GitHub
#176 (comment)
.

@lynndylanhurley
Copy link
Owner

The confirm_success_url param is used to support multiple client applications. If the param isn't required, then the API has no way of knowing where to redirect after email confirmation.

I'm open to allowing an optional default confirm_success_url to be set on the API. Feel free to send a PR if you have time.

@lynndylanhurley
Copy link
Owner

I just pushed a fix for this in version 0.1.32.beta8. You can now set defaults for the email confirmation and password reset redirects. See the config section of the readme for more info.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants