Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Twitter OAuth always throughs CookieOverflow #145

Closed
mkhatib opened this issue Feb 9, 2015 · 6 comments
Closed

Twitter OAuth always throughs CookieOverflow #145

mkhatib opened this issue Feb 9, 2015 · 6 comments

Comments

@mkhatib
Copy link

mkhatib commented Feb 9, 2015

I've tried to fix this up and a lot of what I read online suggests to either not use cookies for the session storage or to remove some attributes from the auth response from twitter which has extra parameter which seems to be too big to store.

@lynndylanhurley
Copy link
Owner

Thanks @mkhatib - I'll look into this ASAP.

@tbloncar
Copy link
Contributor

I went with the suggestion of removing the extra section from the Twitter auth response, and that seemed to fix this. In DeviseTokenAuth::OmniauthCallbacksController#redirect_callbacks:

session['dta.omniauth.auth'] = request.env['omniauth.auth'].except('extra')

Maybe there's a more future-proof solution, but this did the trick.

@lynndylanhurley
Copy link
Owner

@tbloncar - if you send me a PR with that fix I'll merge it right away.

@tbloncar
Copy link
Contributor

@lynndylanhurley Will do this evening. Thanks.

lynndylanhurley added a commit that referenced this issue Mar 12, 2015
Ignore 'extra' in Twitter auth response to avoid CookieOverflow. Fixes #145.
@mkhatib
Copy link
Author

mkhatib commented Mar 12, 2015

👍 💃 thank you guys for getting this in! Will try it as soon as possible and report back!

@lynndylanhurley
Copy link
Owner

Thanks @mkhatib! I'll cut a release later tonight, and I'll post a note here when it's up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants