feat: log who calls sql_json #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| log_params = { | ||
| "user_agent": cast(Optional[str], request.headers.get("USER_AGENT")) | ||
| } | ||
| return self.sql_json_exec(request_json, log_params) |
There was a problem hiding this comment.
You also need to modify sql_json_exec to receive the second parameter, no?
There was a problem hiding this comment.
Yup! That was added in apache#8826 and lyft-master has been updated with the latest apache.
Codecov Report
@@ Coverage Diff @@
## lyft-master #92 +/- ##
===========================================
Coverage 58.1% 58.1%
===========================================
Files 364 364
Lines 11602 11602
Branches 2826 2826
===========================================
Hits 6741 6741
Misses 4669 4669
Partials 192 192Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log who calls the
lyft/sql_jsonendpoint👀 @betodealmeida @DiggidyDave