GET request from filter box

lyft · Apr 21, 2019 · 676bc6b · 676bc6b
1 parent 1895dff
commit 676bc6b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/superset/assets/src/chart/chartAction.js b/superset/assets/src/chart/chartAction.js
@@ -242,7 +242,7 @@ export function exploreJSON(formData, force = false, timeout = 60, key, method)
 
     // clear cache on POST; this happens in Explore view when "Run Query" is
     // clicked, or in the dashboard when force refresh is clicked
-    if (method === 'POST' && 'caches' in self) {
+    if (method === 'POST' && 'caches' in self && force) {
       caches.open(CACHE_KEY).then(supersetCache =>
         supersetCache
           .keys()

diff --git a/superset/assets/src/dashboard/components/Dashboard.jsx b/superset/assets/src/dashboard/components/Dashboard.jsx
@@ -40,7 +40,7 @@ const propTypes = {
   actions: PropTypes.shape({
     addSliceToDashboard: PropTypes.func.isRequired,
     removeSliceFromDashboard: PropTypes.func.isRequired,
-    postChartFormData: PropTypes.func.isRequired,
+    getSavedChart: PropTypes.func.isRequired,
     logEvent: PropTypes.func.isRequired,
   }).isRequired,
   dashboardInfo: dashboardInfoPropShape.isRequired,
@@ -156,7 +156,7 @@ class Dashboard extends React.PureComponent {
           sliceId: chart.id,
         });
 
-        this.props.actions.postChartFormData(
+        this.props.actions.getSavedChart(
           updatedFormData,
           false,
           this.props.timeout,

diff --git a/superset/assets/src/dashboard/containers/Dashboard.jsx b/superset/assets/src/dashboard/containers/Dashboard.jsx
@@ -25,7 +25,7 @@ import {
   addSliceToDashboard,
   removeSliceFromDashboard,
 } from '../actions/dashboardState';
-import { postChartFormData } from '../../chart/chartAction';
+import { getSavedChart } from '../../chart/chartAction';
 import { logEvent } from '../../logger/actions';
 import getLoadStatsPerTopLevelComponent from '../util/logging/getLoadStatsPerTopLevelComponent';
 
@@ -64,7 +64,7 @@ function mapDispatchToProps(dispatch) {
       {
         addSliceToDashboard,
         removeSliceFromDashboard,
-        postChartFormData,
+        getSavedChart,
         logEvent,
       },
       dispatch,