Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow cloning of running executions #93

Merged
merged 2 commits into from
Sep 2, 2020
Merged

Conversation

schottra
Copy link
Contributor

@schottra schottra commented Sep 1, 2020

flyteorg/flyte#468

This allows "relaunch" functionality for an execution which hasn't yet finished. This is helpful for some users who would like to launch multiple copies of an execution with slightly different input parameters.

Also fixed a warning from a test using a deprecated jest-dom method.

image

image

@codecov-commenter
Copy link

Codecov Report

Merging #93 into master will increase coverage by 0.80%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
+ Coverage   66.70%   67.50%   +0.80%     
==========================================
  Files         370      371       +1     
  Lines        5962     5992      +30     
  Branches      930      932       +2     
==========================================
+ Hits         3977     4045      +68     
+ Misses       1985     1947      -38     
Impacted Files Coverage Δ
src/test/utils.ts 93.33% <ø> (ø)
...ExecutionDetails/ExecutionDetailsAppBarContent.tsx 95.65% <100.00%> (+48.15%) ⬆️
...omponents/Executions/ExecutionDetails/constants.ts 100.00% <100.00%> (ø)
src/components/common/MoreOptionsMenu.tsx 100.00% <100.00%> (ø)
src/components/common/constants.ts 100.00% <100.00%> (ø)
src/components/Executions/utils.ts 76.69% <0.00%> (+2.91%) ⬆️
src/components/Executions/ExecutionStatusBadge.tsx 90.90% <0.00%> (+4.54%) ⬆️
...ns/TerminateExecution/TerminateExecutionButton.tsx 100.00% <0.00%> (+42.85%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0b1f5c...969006b. Read the comment docs.

Copy link

@podehnal podehnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@service-github-lyft-semantic-release
Copy link
Contributor

🎉 This PR is included in version 0.11.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants