fix: only filter NodeExecutions when viewing the Nodes tab #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BobNisco
reviewed
Aug 12, 2020
| @@ -1,7 +1,7 @@ | |||
| import { useState } from 'react'; | |||
|
|
|||
| export function useTabState( | |||
| tabs: { [k: string]: string }, | |||
| tabs: { [k: string]: string | object }, | |||
There was a problem hiding this comment.
Should we type this?
Suggested change
| tabs: { [k: string]: string | object }, | |
| tabs: { [k: string]: string | { id: string; label: string } }, |
There was a problem hiding this comment.
Good suggestion. At the moment, the shape of the object doesn't matter. So I'm okay leaving it generic.
Codecov Report
@@ Coverage Diff @@
## master #88 +/- ##
==========================================
+ Coverage 63.86% 66.22% +2.36%
==========================================
Files 366 367 +1
Lines 5856 5860 +4
Branches 892 893 +1
==========================================
+ Hits 3740 3881 +141
+ Misses 2116 1979 -137
Continue to review full report at Codecov.
|
13 tasks
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Aug 13, 2020
## [0.8.1](http://github.com/lyft/flyteconsole/compare/v0.8.0...v0.8.1) (2020-08-13) ### Bug Fixes * only use NE filter for Nodes tab ([#88](http://github.com/lyft/flyteconsole/issues/88)) ([f4ba80b](http://github.com/lyft/flyteconsole/commit/f4ba80b0498a0b37dc73ed3c3c8e72844101dcb5))
|
🎉 This PR is included in version 0.8.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flyteorg/flyte#425
We share the loaded NodeExecutions between the two tabs on the ExecutionDetails page.
This is a useful performance optimization when both are viewing an unfiltered list of NodeExecutions. But it results in missing node information when a filter is applied in the Nodes tab and then the Graph tab is opened.
To address this, I updated the logic in
ExecutionNodeViewsto only pass the filter list if the current tab is the Nodes tab. This has the effect of resetting the fetchable for NodeExecutions when the tab is changed if a filter is applied. But if no filter is applied, the passed list will be empty in all cases, resulting in reuse of the previously-fetched data.The majority of this PR is actually cleanup work done to facilitate writing a unit test to cover the new behavior 😁