fix: Expose cluster information for Workflow Executions #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 62.88% 63.06% +0.17%
==========================================
Files 361 363 +2
Lines 5647 5685 +38
Branches 837 840 +3
==========================================
+ Hits 3551 3585 +34
- Misses 2096 2100 +4
Continue to review full report at Codecov.
|
BobNisco
previously approved these changes
Jun 30, 2020
src/components/Executions/ExecutionDetails/ExecutionMetadata.tsx
Outdated
Show resolved
Hide resolved
BobNisco
approved these changes
Jul 1, 2020
service-github-lyft-semantic-release
added a commit
that referenced
this pull request
Jul 1, 2020
## [0.7.1](http://github.com/lyft/flyteconsole/compare/v0.7.0...v0.7.1) (2020-07-01) ### Bug Fixes * Expose cluster information for Workflow Executions ([#78](http://github.com/lyft/flyteconsole/issues/78)) ([d43a1e3](http://github.com/lyft/flyteconsole/commit/d43a1e393ef7b0651f9774460e3d7166a3b57f17))
|
🎉 This PR is included in version 0.7.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary goal was to expose a piece of metadata that is useful in debugging. But since the portion of the page where we show execution details is already pretty crowded, I decided to implement a restyling that would be part of some upcoming design changes for the execution details page. This gave me more room to add the extra piece of information
spec.metadata.systemMetadata.executionClusterNameproperty will just show "(unknown)"Before:
After:
Expansions:
