Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding automatic image building and release management #69

Merged
merged 15 commits into from
Jun 30, 2020

Conversation

schottra
Copy link
Contributor

@schottra schottra commented May 5, 2020

  • Pulled in the latest boilerplate to get some shared github actions.
  • Began using the GH action to build/push images for pull requests
  • Added a semantic-release config to allow automatic generation of release notes and releases when merging changes to master. See semantic-release docs for more info.
  • Added commit linting to ensure that commits follow conventional commit standards. This helps us with the automatic release generation process.
  • fixed a test that was flaky on CI due to the expectation that an event loop would take at least 1ms to complete.

@codecov-io
Copy link

codecov-io commented May 6, 2020

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   58.65%   58.65%           
=======================================
  Files         363      363           
  Lines        5664     5664           
  Branches      847      847           
=======================================
  Hits         3322     3322           
  Misses       2342     2342           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4d9b03...c3c3fcc. Read the comment docs.

@schottra schottra force-pushed the github-actions branch 5 times, most recently from d72c7d1 to 026676a Compare May 9, 2020 00:01
@schottra schottra changed the title Adding github workflows for images/tags feat: Adding automatic image building and release management May 9, 2020
@schottra schottra force-pushed the github-actions branch 14 times, most recently from a8673af to c3c3fcc Compare May 14, 2020 21:53
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2020

Codecov Report

Merging #69 into master will increase coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
+ Coverage   59.13%   59.22%   +0.08%     
==========================================
  Files         364      365       +1     
  Lines        5673     5687      +14     
  Branches      847      847              
==========================================
+ Hits         3355     3368      +13     
- Misses       2318     2319       +1     
Impacted Files Coverage Δ
src/components/common/DropDownWindowButton.tsx 33.33% <0.00%> (ø)
src/routes/index.ts 100.00% <0.00%> (ø)
src/common/layout.ts 100.00% <0.00%> (ø)
src/models/Node/index.ts 100.00% <0.00%> (ø)
src/models/Task/index.ts 100.00% <0.00%> (ø)
src/models/Graph/index.ts 100.00% <0.00%> (ø)
src/models/Project/index.ts 100.00% <0.00%> (ø)
src/models/Workflow/index.ts 100.00% <0.00%> (ø)
src/components/hooks/index.ts 100.00% <0.00%> (ø)
src/models/Execution/index.ts 100.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07796a8...7e6507c. Read the comment docs.

@schottra schottra force-pushed the github-actions branch 4 times, most recently from 4ecbf13 to d4cfe4c Compare June 29, 2020 20:47
EngHabu
EngHabu previously approved these changes Jun 29, 2020
@service-github-lyft-semantic-release
Copy link
Contributor

🎉 This PR is included in version 0.6.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants