fix: on project select navigate to corresponding ProjectDashboard #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nastya Rusina <[email protected]>
anrusina
requested review from
a team,
ursucarina,
jsonporter and
olga-union
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #420 +/- ##
=======================================
Coverage 67.08% 67.08%
=======================================
Files 407 407
Lines 9147 9147
Branches 1614 1614
=======================================
Hits 6136 6136
Misses 3011 3011
Continue to review full report at Codecov.
|
kumare3
approved these changes
Apr 22, 2022
flyte-bot
added a commit
that referenced
this pull request
Apr 22, 2022
## [0.54.2](http://github.com/lyft/flyteconsole/compare/v0.54.1...v0.54.2) (2022-04-22) ### Bug Fixes * on project select navigate to corresponding ProjectDashboard ([#420](http://github.com/lyft/flyteconsole/issues/420)) ([a855f9b](http://github.com/lyft/flyteconsole/commit/a855f9b523b12a0b1fa0e4d1df09ff6d5e31b1b9))
|
🎉 This PR is included in version 0.54.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before we introduces ProjectDashboard page, the most top level view was Workflows page, so navigating to it was a logical decision.
Now it is more logical to navigate user to ProjectDashboard page for selected peoject/domain from project list selection
/consolesection.Video with the fix: https://share.getcloudapp.com/8LuDNkBr
Type
Are all requirements met?
Signed-off-by: Nastya Rusina [email protected]