-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: archive tasks #395
feat: archive tasks #395
Conversation
Codecov Report
@@ Coverage Diff @@
## master #395 +/- ##
==========================================
+ Coverage 66.43% 67.18% +0.74%
==========================================
Files 405 407 +2
Lines 9063 9133 +70
Branches 1600 1609 +9
==========================================
+ Hits 6021 6136 +115
+ Misses 3042 2997 -45
Continue to review full report at Codecov.
|
Signed-off-by: Carina Ursu <[email protected]>
b686432
to
08a09a7
Compare
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left two placement comments, can you please fix them before merge
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
# [0.53.0](http://github.com/lyft/flyteconsole/compare/v0.52.1...v0.53.0) (2022-04-16) ### Features * archive tasks ([#395](http://github.com/lyft/flyteconsole/issues/395)) ([9ce77a7](http://github.com/lyft/flyteconsole/commit/9ce77a70e75642fe5413dbee7d59e17285d12e36))
🎉 This PR is included in version 0.53.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Signed-off-by: Carina Ursu [email protected]
New feature: Archive/Unarchive tasks from flyteconsole
Archive Button: https://share.getcloudapp.com/8LuDYmNp
Archive Actions: https://share.getcloudapp.com/yAuK98ep
Type
Are all requirements met?
Complete description
Added TaskExecutionState enum and calls to NamedEntityUpdate
Added notistack to support error and success notifications
Ensured that items could be archived and unarchived from "tasks"
Added "localization" string support