Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: archive tasks #395

Merged
merged 5 commits into from
Apr 16, 2022
Merged

feat: archive tasks #395

merged 5 commits into from
Apr 16, 2022

Conversation

ursucarina
Copy link
Contributor

@ursucarina ursucarina commented Apr 15, 2022

Signed-off-by: Carina Ursu [email protected]

New feature: Archive/Unarchive tasks from flyteconsole

Archive Button: https://share.getcloudapp.com/8LuDYmNp
Archive Actions: https://share.getcloudapp.com/yAuK98ep

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Added TaskExecutionState enum and calls to NamedEntityUpdate
Added notistack to support error and success notifications
Ensured that items could be archived and unarchived from "tasks"
Added "localization" string support

@ursucarina ursucarina requested review from anrusina, olga-union, a team and jsonporter and removed request for a team April 15, 2022 20:29
@codecov
Copy link

codecov bot commented Apr 15, 2022

Codecov Report

Merging #395 (5e444bc) into master (ea9d2b3) will increase coverage by 0.74%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##           master     #395      +/-   ##
==========================================
+ Coverage   66.43%   67.18%   +0.74%     
==========================================
  Files         405      407       +2     
  Lines        9063     9133      +70     
  Branches     1600     1609       +9     
==========================================
+ Hits         6021     6136     +115     
+ Misses       3042     2997      -45     
Impacted Files Coverage Δ
src/components/common/strings.ts 100.00% <ø> (ø)
src/models/Workflow/api.ts 72.72% <ø> (ø)
...components/Workflow/SearchableWorkflowNameList.tsx 72.88% <15.38%> (+0.61%) ⬆️
src/models/Task/api.ts 72.72% <57.14%> (-27.28%) ⬇️
...rc/components/common/FilterableNamedEntityList.tsx 86.20% <86.20%> (ø)
src/components/Task/SearchableTaskNameList.tsx 85.10% <90.00%> (+85.10%) ⬆️
...rc/components/Navigation/SearchableProjectList.tsx 100.00% <100.00%> (ø)
src/components/Project/ProjectTasks.tsx 100.00% <100.00%> (+100.00%) ⬆️
src/components/Task/useTaskShowArchivedState.ts 100.00% <100.00%> (ø)
src/components/Task/utils.ts 100.00% <100.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1f55f4...5e444bc. Read the comment docs.

Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
@ursucarina ursucarina requested a review from olga-union April 15, 2022 22:28
Copy link
Contributor

@anrusina anrusina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left two placement comments, can you please fix them before merge

src/models/Task/enums.ts Outdated Show resolved Hide resolved
src/test/modelUtils.ts Outdated Show resolved Hide resolved
Signed-off-by: Carina Ursu <[email protected]>
Signed-off-by: Carina Ursu <[email protected]>
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.53.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Archive] Allow to archive tasks from flyteconsole
4 participants