Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(383): tasks and workflow number capped to 25 in dashboard page #384

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

anrusina
Copy link
Contributor

Signed-off-by: Nastya Rusina [email protected]

Now Project domain page for flytecsnacks looks like:
Screen Shot 2022-04-13 at 3 28 15 PM

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Added NONE limit to request which is currently corresponds to 10000 items.
We requested a new API from backend to return total number of items, which is tracked by https://github.com/flyteorg/flyteconsole/issues/382

Tracking Issue

fixes https://github.com/flyteorg/flyteconsole/issues/383

@anrusina anrusina requested review from a team, ursucarina, jsonporter and olga-union and removed request for a team April 13, 2022 22:28
Copy link
Contributor

@olga-union olga-union left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a quick fix!

@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #384 (6800016) into master (2e250bb) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #384   +/-   ##
=======================================
  Coverage   66.44%   66.45%           
=======================================
  Files         405      405           
  Lines        9058     9059    +1     
  Branches     1599     1599           
=======================================
+ Hits         6019     6020    +1     
  Misses       3039     3039           
Impacted Files Coverage Δ
src/components/Project/ProjectDashboard.tsx 98.59% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c13289d...6800016. Read the comment docs.

@anrusina anrusina merged commit a8c0ab8 into master Apr 13, 2022
@anrusina anrusina deleted the narusina/cap branch April 13, 2022 22:42
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.51.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Workflow and Tasks number is capped to 25 in ProjectDashboard page
3 participants