fix(bug_339): show tooltip on chart bars hover #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nastya Rusina <[email protected]>
anrusina
requested review from
a team,
jsonporter and
olga-union
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## master #340 +/- ##
==========================================
+ Coverage 65.14% 65.18% +0.03%
==========================================
Files 390 390
Lines 8707 8702 -5
Branches 1506 1502 -4
==========================================
Hits 5672 5672
+ Misses 3035 3030 -5
Continue to review full report at Codecov.
|
olga-union
approved these changes
Mar 23, 2022
flyte-bot
added a commit
that referenced
this pull request
Mar 23, 2022
## [0.47.1](http://github.com/lyft/flyteconsole/compare/v0.47.0...v0.47.1) (2022-03-23) ### Bug Fixes * **bug_339:** show tooltip on chart bars hover ([#340](http://github.com/lyft/flyteconsole/issues/340)) ([1006239](http://github.com/lyft/flyteconsole/commit/1006239d6aca9498c6a90cd4f7f10d57213b1c87))
|
🎉 This PR is included in version 0.47.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nastya Rusina [email protected]
This PR:
During testing I found a bug, that the BarChart doesn't show the tooltip anymore. Tested this component due to typings changes required in getBoundingClientRect() function which is used by BarChartItem.
I looked into Demo site, and found that we are not showing up a tooltip for quite a time now.
Type
Are all requirements met?
Tracking Issue
fixes https://github.com/flyteorg/flyteconsole/issues/339