Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable timeline view #327

Merged
merged 1 commit into from
Mar 15, 2022
Merged

feat: enable timeline view #327

merged 1 commit into from
Mar 15, 2022

Conversation

anrusina
Copy link
Contributor

@anrusina anrusina commented Mar 15, 2022

This PR enables Timeline view on workflow execution page for everyone.
All guarding feature flags are removed.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

How it looks now

Screen Shot 2022-03-15 at 8 14 53 AM

Tracking Issue

fixes https://github.com/flyteorg/flyteconsole/issues/302

@anrusina anrusina requested review from a team, jsonporter and olga-union and removed request for a team March 15, 2022 15:18
Signed-off-by: Nastya Rusina <[email protected]>
@anrusina anrusina force-pushed the narusina/timeline branch from 07cff21 to a4cd1c6 Compare March 15, 2022 15:18
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #327 (a4cd1c6) into master (ae63316) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #327      +/-   ##
==========================================
- Coverage   64.89%   64.86%   -0.04%     
==========================================
  Files         390      390              
  Lines        8990     8979      -11     
  Branches     1626     1623       -3     
==========================================
- Hits         5834     5824      -10     
+ Misses       3156     3155       -1     
Impacted Files Coverage Δ
src/basics/FeatureFlags/defaultConfig.ts 100.00% <100.00%> (ø)
src/basics/LocalCache/defaultConfig.ts 100.00% <100.00%> (ø)
...Executions/ExecutionDetails/ExecutionNodeViews.tsx 97.29% <100.00%> (+1.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae63316...a4cd1c6. Read the comment docs.

Copy link
Contributor

@jsonporter jsonporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.45.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Execution Timeline View
4 participants