feat: handle 'Aborting' workflow execution phases #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Katrina Rogan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #256 +/- ##
=========================================
Coverage ? 63.82%
=========================================
Files ? 370
Lines ? 8114
Branches ? 1442
=========================================
Hits ? 5179
Misses ? 2935
Partials ? 0 Continue to review full report at Codecov.
|
govalt
approved these changes
Jan 6, 2022
flyte-bot
added a commit
that referenced
this pull request
Jan 6, 2022
# [0.38.0](http://github.com/lyft/flyteconsole/compare/v0.37.1...v0.38.0) (2022-01-06) ### Features * handle 'Aborting' workflow execution phases ([#256](http://github.com/lyft/flyteconsole/issues/256)) ([3231441](http://github.com/lyft/flyteconsole/commit/3231441e38b782eb83f754a8e4aa7c7ed19ce9e1))
|
🎉 This PR is included in version 0.38.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
govalt
pushed a commit
that referenced
this pull request
Jan 15, 2022
Signed-off-by: Katrina Rogan <[email protected]> Signed-off-by: csirius <[email protected]>
govalt
pushed a commit
that referenced
this pull request
Jan 15, 2022
# [0.38.0](http://github.com/lyft/flyteconsole/compare/v0.37.1...v0.38.0) (2022-01-06) ### Features * handle 'Aborting' workflow execution phases ([#256](http://github.com/lyft/flyteconsole/issues/256)) ([3231441](http://github.com/lyft/flyteconsole/commit/3231441e38b782eb83f754a8e4aa7c7ed19ce9e1)) Signed-off-by: csirius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Katrina Rogan [email protected]
TL;DR
Workflow executions now transition from 'running' -> 'aborting' -> 'aborted'. This change handles rendering the 'aborting' phase.
Note: I wasn't sure whether it was worth updating the workflow status filters since this phase is transitive and ideally short-lived
Type
Are all requirements met?
Complete description
See linked issue below.
Tracking Issue
flyteorg/flyte#1978
Follow-up issue
NA