Fix: Fixed missing Authrole values on ExecutionMetaDataExtra #255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Porter <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #255 +/- ##
=========================================
Coverage ? 63.82%
=========================================
Files ? 370
Lines ? 8114
Branches ? 1442
=========================================
Hits ? 5179
Misses ? 2935
Partials ? 0 Continue to review full report at Codecov.
|
jsonporter
changed the title
flyte-bot
added a commit
that referenced
this pull request
Jan 5, 2022
## [0.37.1](http://github.com/lyft/flyteconsole/compare/v0.37.0...v0.37.1) (2022-01-05) ### Bug Fixes * Fixed missing Authrole values on ExecutionMetaDataExtra ([#255](http://github.com/lyft/flyteconsole/issues/255)) ([71af238](http://github.com/lyft/flyteconsole/commit/71af238e7fe9b9e0c698627865c807ff981fbaac))
|
🎉 This PR is included in version 0.37.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
govalt
pushed a commit
that referenced
this pull request
Jan 15, 2022
Signed-off-by: Jason Porter <[email protected]> Signed-off-by: csirius <[email protected]>
govalt
pushed a commit
that referenced
this pull request
Jan 15, 2022
## [0.37.1](http://github.com/lyft/flyteconsole/compare/v0.37.0...v0.37.1) (2022-01-05) ### Bug Fixes * Fixed missing Authrole values on ExecutionMetaDataExtra ([#255](http://github.com/lyft/flyteconsole/issues/255)) ([71af238](http://github.com/lyft/flyteconsole/commit/71af238e7fe9b9e0c698627865c807ff981fbaac)) Signed-off-by: csirius <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix addresses a bug where authRole values would be missing from ExecutionData header. This fix also includes adding both IAM and k8 values.
Type
Are all requirements met?
Complete description
Values for authRole of an execution will not be returned with getLaunchPlan(); this fix correctly uses the execution.spec to populate those values.
Tracking Issue
NA
Follow-up issue
NA