Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add advanced launch options to execution details #242

Merged
merged 2 commits into from
Dec 7, 2021

Conversation

govalt
Copy link
Contributor

@govalt govalt commented Nov 22, 2021

Signed-off-by: csirius [email protected]

TL;DR

Add advanced launch options to execution details page.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Add Service Account, Raw Output Prefix, and Parallelism to execution details page.

Tracking Issue

fixes flyteorg/flyte#1761

Follow-up issue

NA

jsonporter
jsonporter previously approved these changes Nov 22, 2021
Copy link
Contributor

@jsonporter jsonporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@30091af). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #242   +/-   ##
=========================================
  Coverage          ?   63.64%           
=========================================
  Files             ?      366           
  Lines             ?     7950           
  Branches          ?     1392           
=========================================
  Hits              ?     5060           
  Misses            ?     2890           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30091af...5c9bf1d. Read the comment docs.

Copy link
Contributor

@jsonporter jsonporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsonporter jsonporter merged commit 711600d into master Dec 7, 2021
@jsonporter jsonporter deleted the feat/execution-details-advanced-option branch December 7, 2021 18:44
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.33.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[UI Feature] Execution details page should show all the Advanced options selected for the execution
3 participants