Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add pagination for child node expansion #232

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

govalt
Copy link
Contributor

@govalt govalt commented Oct 15, 2021

Signed-off-by: csirius [email protected]

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Added pagination for loading child execution nodes.

Tracking Issue

NA

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@2a326cd). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #232   +/-   ##
=========================================
  Coverage          ?   63.59%           
=========================================
  Files             ?      364           
  Lines             ?     7879           
  Branches          ?     1378           
=========================================
  Hits              ?     5011           
  Misses            ?     2868           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2a326cd...3648ce8. Read the comment docs.

Copy link
Contributor

@Pianist038801 Pianist038801 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.29.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@anrusina anrusina deleted the hotfix-nodes-pagination branch January 14, 2022 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants