feat: add popover for bar chart item hover state #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: csirius <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #217 +/- ##
=========================================
Coverage ? 63.70%
=========================================
Files ? 361
Lines ? 7744
Branches ? 1343
=========================================
Hits ? 4933
Misses ? 2811
Partials ? 0 Continue to review full report at Codecov.
|
| @@ -88,6 +106,13 @@ export const EntityExecutionsBarChart: React.FC<EntityExecutionsBarChartProps> = | |||
| } | |||
| ); | |||
|
|
|||
| const handleClickItem = React.useCallback(item => { | |||
| if (item.metadata) { | |||
| // const executionId = item.metadata as WorkflowExecutionIdentifier; | |||
There was a problem hiding this comment.
@csirius Maybe, is this commented out by intention?
There was a problem hiding this comment.
@Pianist038801
Yes, actually I added routing mechanism for the item click but for next week's demo, we shouldn't include it so just commented it out.
jsonporter
approved these changes
Sep 24, 2021
flyte-bot
added a commit
that referenced
this pull request
Sep 24, 2021
# [0.27.0](http://github.com/lyft/flyteconsole/compare/v0.26.0...v0.27.0) (2021-09-24) ### Bug Fixes * polish workflow details page ([#215](http://github.com/lyft/flyteconsole/issues/215)) ([dba3df1](http://github.com/lyft/flyteconsole/commit/dba3df1c5509b9a1aef7c903810551f329308631)) ### Features * add popover for bar chart item hover state ([#217](http://github.com/lyft/flyteconsole/issues/217)) ([46a7823](http://github.com/lyft/flyteconsole/commit/46a7823f785fd917f48d61e9b5dc1b81c3e3e33a))
|
🎉 This PR is included in version 0.27.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: csirius [email protected]
TL;DR
Add popover to bar chart item
Type
Are all requirements met?
Complete description
Added Popover to bar chart item with execution id, runtime duration and started at time.
Tracking Issue
fixes flyteorg/flyte#1465
Follow-up issue
NA