Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add min height for all executions list #214

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

govalt
Copy link
Contributor

@govalt govalt commented Sep 23, 2021

Signed-off-by: csirius [email protected]

TL;DR

Add min-height for the All executions in the workflow view.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Add min-height to the entity executions view and make it scrollable.

Tracking Issue

fixes flyteorg/flyte#1517

Follow-up issue

NA

@codecov
Copy link

codecov bot commented Sep 23, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@6c8c39e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #214   +/-   ##
=========================================
  Coverage          ?   63.82%           
=========================================
  Files             ?      361           
  Lines             ?     7729           
  Branches          ?     1339           
=========================================
  Hits              ?     4933           
  Misses            ?     2796           
  Partials          ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8c39e...b2b8405. Read the comment docs.

@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 0.26.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@anrusina anrusina deleted the executions-list-height branch January 13, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Add a fixed height to "All Executions in the Workflow" view
3 participants