fix: hide recover button for successful executions #203
Conversation
Codecov Report
@@ Coverage Diff @@
## master #203 +/- ##
=========================================
Coverage ? 65.89%
=========================================
Files ? 354
Lines ? 7412
Branches ? 1257
=========================================
Hits ? 4884
Misses ? 2528
Partials ? 0 Continue to review full report at Codecov.
|
| {[ | ||
| WorkflowExecutionPhase.FAILED, | ||
| WorkflowExecutionPhase.ABORTED, | ||
| WorkflowExecutionPhase.TIMED_OUT | ||
| ].includes(phase) && ( |
There was a problem hiding this comment.
Could we change this to const isRecoverVisible = React.useMemo(() => [WorkflowExecutionPhase.FAILED,WorkflowExecutionPhase.ABORTED,WorkflowExecutionPhase.TIMED_OUT].includes(phase), [phase]); and use that variable in dom?
Just my suggestion, ;)
There was a problem hiding this comment.
Nice catch, just pushed the fix.
Signed-off-by: Pianist038801 <[email protected]>
Pianist038801
force-pushed
the
fix/hide-recover-button-for-successful-executions
branch
from
65a2b3f to
81bf2e5
Compare
## [0.25.3](http://github.com/lyft/flyteconsole/compare/v0.25.2...v0.25.3) (2021-09-16) ### Bug Fixes * hide recover button for successful executions ([#203](http://github.com/lyft/flyteconsole/issues/203)) ([81dd608](http://github.com/lyft/flyteconsole/commit/81dd608d8605522a2c08725dc2986c933ee1deb5))
|
🎉 This PR is included in version 0.25.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
anrusina
deleted the
fix/hide-recover-button-for-successful-executions
branch
Signed-off-by: Pianist038801 [email protected]
This hides recover button for the successful executions.
Type
Are all requirements met?
Tracking Issue
fixes flyteorg/flyte#1416
Follow-up issue
NA